[CodeCompletion] Always print argument ':' in filterName #72887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
commented
Apr 6, 2024
| @@ -234,60 +234,58 @@ void CodeCompletionResultBuilder::setAssociatedDecl(const Decl *D) { | |||
| void CodeCompletionResultBuilder::addCallArgument( | |||
| Identifier Name, Identifier LocalName, Type Ty, Type ContextTy, | |||
| bool IsVarArg, bool IsInOut, bool IsIUO, bool IsAutoClosure, | |||
| bool UseUnderscoreLabel, bool IsLabeledTrailingClosure, bool HasDefault) { | |||
| bool IsLabeledTrailingClosure, bool IsForOperator, bool HasDefault) { | |||
There was a problem hiding this comment.
UseUnderscoreLabel was meant to indicate "is labeled trailing closure" when it's introduced 😅
In annotated results. rdar://124667867
rintaro
force-pushed
the
ide-completion-rdar124667867
branch
from
27657d2 to
46cc32e
Compare
|
@swift-ci Please smoke test |
hamishknight
approved these changes
Apr 8, 2024
ahoppen
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In annotated results.
rdar://124667867