[6.0][Distributed] Diagnose missing import also for funcs in extensions #72928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
ktoso
changed the title
ktoso
added
distributed
|
@swift-ci please test |
|
Cherry pick AFTER #72974 to avoid conflicts |
ktoso
force-pushed
the
pick-wip-diagnose-missing-import
branch
from
ec7b8f4 to
a73d588
Compare
|
@swift-ci please test |
Resolves rdar://125813581
ktoso
force-pushed
the
pick-wip-diagnose-missing-import
branch
from
a73d588 to
b39e0b9
Compare
ktoso
force-pushed
the
pick-wip-diagnose-missing-import
branch
from
b39e0b9 to
6ad9fa3
Compare
|
@swift-ci please test |
|
rebased post-#72974 |
|
@swift-ci please test Linux |
1 similar comment
|
@swift-ci please test Linux |
|
@swift-ci please test |
hborla
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: When a distributed func was declared in an extension in a file that did not import the Distributed module, though the extension was made properly on a distributed actor, we would crash in synthesis in SILGen because synthesis refers to types in the distributed module and the import is necessary.
This patch properly diagnoses missing imports whenever a distributed func is used somewhere.
Reviewed by: @xedin
Risk: Low, only improved diagnostics rather than crashing the compiler for distributed func declarations.
Testing: CI testing, verified manually in Xcode project of original issue reporter
Original PR: #72923 #72948
Radar: rdar://125813581 rdar://120761584