Skip to content

[embedded][wasm] Fix missing putchar symbol in test #72973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kateinoigakukun
Copy link
Member

Baremetal Wasm targets do not have stdio, so we need to provide a stub putchar. Also use @_extern(c) instead of @_silgen_name for putchar to fix signature mismatch

@kateinoigakukun
Copy link
Member Author

@swift-ci smoke test

@kateinoigakukun
Copy link
Member Author

@swift-ci test WebAssembly

Using inconsistent attributes between stdlib and tests causes
compilation errors. There are still several misuses of @_silgen_name in
tests, but leaving them as is for now to incrementally fix them.
@kateinoigakukun
Copy link
Member Author

@swift-ci test WebAssembly

@kateinoigakukun
Copy link
Member Author

@swift-ci smoke test

@kateinoigakukun kateinoigakukun marked this pull request as ready for review April 11, 2024 13:42
@kateinoigakukun kateinoigakukun requested a review from a team as a code owner April 11, 2024 13:42
@kateinoigakukun kateinoigakukun merged commit 10410f1 into swiftlang:main Apr 11, 2024
@kateinoigakukun kateinoigakukun deleted the yt/repair-embedded-wasm-class branch April 11, 2024 15:06
@kateinoigakukun kateinoigakukun added the WebAssembly Platform: WebAssembly label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebAssembly Platform: WebAssembly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant