Skip to content

[6.0][CodeCompletion] Always print argument ':' in filterName #73118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2024
Merged

[6.0][CodeCompletion] Always print argument ':' in filterName #73118

merged 1 commit into from
Apr 19, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Apr 18, 2024 •
edited
Loading

Cherry-pick #72887 into release/6.0

  • Explanation: In code completion's call patterns, when a parameter has empty parameter name and argument name i.e. (_:), filterName didn't emit :. This PR changes it to always emit :, so that clients know the number of parameters from it.
  • Scope: Code completion
  • Risk: Low. The change only affects code completion
  • Testing: Added regression test cases
  • Issue: rdar://124667867
  • Reviewer: Hamish Knight (@hamishknight) Alex Hoppen (@ahoppen)

@rintaro
[CodeCompletion] Always print argument ':' in filterName
69d644f 
In annotated results.

rdar://124667867
(cherry picked from commit 46cc32e)
@rintaro rintaro requested a review from a team as a code owner April 18, 2024 21:38
@rintaro
Copy link
Member Author

rintaro commented Apr 18, 2024

@swift-ci Please test

@rintaro rintaro enabled auto-merge April 18, 2024 21:59
@rintaro rintaro merged commit 8455075 into swiftlang:release/6.0 Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @bnbarham