[6.0 cherry-pick][embedded] Consider move_value/copy_value as removable for keypath optimization #73214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kubamracek
commented
Apr 24, 2024
kubamracek
commented
- Explanation: Embedded Swift allows keypaths as long as they don't require any runtime instances to exist. This PR fixes a problem when using keypaths in @dynamicMemberLookup subscript setters, where we end up having move_value or copy_value instructions on the keypath values in SIL. [embedded] Consider move_value/copy_value as removable for keypath optimization #73184
- Scope: The problem that this change solves exists in Embedded Swift only, but the fix is in the SIL mandatory optimization pipeline which is used in regular compilations too.
- Risk: Well-understood simple fix in a specific optimization pass.
- Testing: Added test case.
- Issue: rdar://126655571
- Reviewer: @eeckstein on [embedded] Consider move_value/copy_value as removable for keypath optimization #73184
|
@swift-ci please test |
|
@swift-ci please test |
eeckstein
approved these changes
Apr 25, 2024
tbkka
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.