[MoveOnlyAddressChecker] Don't complete reborrows or their adjacent phis. #73358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After 874971c, before running address checking, all lifetimes in the function are completed. That doesn't quite work because lifetime completion expects not to encounter reborrows or their adjacent phis.
|
@swift-ci please test |
atrick
approved these changes
May 1, 2024
nate-chandler
added a commit
to nate-chandler/swift
that referenced
this pull request
May 16, 2025
Apply the MoveOnlyAddressChecker change from swiftlang#73358 to the MoveOnly[Value]Checker. After 7713eef, before running value checking, all lifetimes in the function are completed. That doesn't quite work because lifetime completion expects not to encounter reborrows or their adjacent phis. rdar://151325025
nate-chandler
added a commit
to nate-chandler/swift
that referenced
this pull request
May 16, 2025
Apply the MoveOnlyAddressChecker change from swiftlang#73358 to the MoveOnly[Value]Checker. After 7713eef, before running value checking, all lifetimes in the function are completed. That doesn't quite work because lifetime completion expects not to encounter reborrows or their adjacent phis. rdar://151325025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 874971c, before running address checking, all lifetimes in the function are completed. That doesn't quite work because lifetime completion expects not to encounter reborrows or their adjacent phis.
rdar://127312637