Skip to content

[NFC] LifetimeCompletion: Clarified API and documentation. #73368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nate-chandler
Copy link
Contributor

Improved some naming, documentation, and API.

Completion is done along a boundary, either the availability or the
liveness boundary.  Represent which with a type.  Update docs and names.
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler nate-chandler requested review from atrick and meg-gupta May 1, 2024 18:02
@nate-chandler nate-chandler merged commit d5aafbc into swiftlang:main May 2, 2024
@nate-chandler nate-chandler deleted the lifetime-completion/20240501/1 branch May 2, 2024 01:02
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants