[6.0] Lost variables statistics + Fix -Onone #73398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Snowy1803
commented
May 2, 2024
Snowy1803
commented
- Explanation: This PR adds a compile flag to emit lost variables statistics, which is disabled by default. Additionally, it fixes lost variables at Onone in some later passes.
- Scope: Salvages lost debug values in some passes. Add optional statistics.
- Original PR: Add compile flag for lost debug variables statistics #73334 + [DebugInfo] Fix loss of variables at -Onone #73387
- Risk: Low, adds an -Xllvm compile flag disabled by default, fix scope and missing variables in rare cases.
- Testing: New tests have been added, existing ones have been updated
- Issue: None
- Reviewer: @adrian-prantl
(cherry picked from commit 59d0bd4)
(cherry picked from commit 7e81fd6)
(cherry picked from commit 711e964)
(cherry picked from commit f6232a9)
LoadableByAddress was losing debug info, including at -Onone. When converting a load-store pair to a copy_addr, the debug info attached to the load was not salvaged. Additionally, the wrong scope was being attached to other debug values. (cherry picked from commit 644509e)
AllocStackHoisting was losing debug info, including at -Onone. When two alloc_stacks of the same type are merged, one of them would lose their debug variable. It is now salvaged, with an added debug_value. This case was previously only handled for noncopyable types, it is now done in all cases. (cherry picked from commit c02f663)
|
@swift-ci please test |
adrian-prantl
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.