Tidy up Python file handlers #735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than using `f = open(path).read()`, which leaves the file open for an indeterminate period of time, switch to the `with open(path) as f` idiom, which ensures the file is always closed correctly.
| outFile.write("}\n") | ||
| outFile.flush() | ||
| os.fsync(outFile.fileno()) | ||
| outFile.close |
There was a problem hiding this comment.
I wonder how this ever worked.
gribozavr
added a commit
that referenced
this pull request
Dec 23, 2015
Tidy up Python file handlers
gribozavr
added a commit
that referenced
this pull request
Dec 23, 2015
Fix syntax error and double open introduced in #735
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using
f = open(path).read(), which leaves the file openfor an indeterminate period of time, switch to the
with open(path) as fidiom, which ensures the file is always closed correctly.