Skip to content

[6.0🍒] NCGenerics: it's not experimental #73514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2024

Conversation

kavon
Copy link
Member

@kavon kavon commented May 8, 2024

  • Explanation: Ensures that feature-guards in interfaces always evaluate to true for $NoncopyableGenerics, regardless of whether the module was built with -enable-experimental-feature NoncopyableGenerics.
  • Scope: Important for people who start using the feature without the flag in their build configuration, so they actually emit correct swiftinterface files.
  • Issue: rdar://127701059
  • Original PR: NCGenerics: it's not experimental #73501
  • Risk: Low.
  • Testing:
  • Reviewer: @egorzhdan reviewed the C++ interop bits

@kavon kavon changed the base branch from main to release/6.0 May 8, 2024 18:38
@kavon
Copy link
Member Author

kavon commented May 8, 2024

@swift-ci test

@kavon
Copy link
Member Author

kavon commented May 8, 2024

@swift-ci test macOS

@kavon
Copy link
Member Author

kavon commented May 13, 2024

@swift-ci test macOS platform

resolves rdar://127701059

(cherry picked from commit 0420310)
@kavon kavon force-pushed the 6.0-ncgeneric-not-experimental branch from 1c89f9f to a68e9c4 Compare May 13, 2024 16:25
@kavon
Copy link
Member Author

kavon commented May 13, 2024

@swift-ci test macOS platform

@kavon kavon force-pushed the 6.0-ncgeneric-not-experimental branch from a68e9c4 to d10a31d Compare May 13, 2024 18:12
@kavon
Copy link
Member Author

kavon commented May 13, 2024

@swift-ci test

We haven't yet solved the underlying issue in rdar://128013193 and the
workaround to make it conditionally use the better importing strategy of
Unsafe{Mutable}Pointer no longer will apply, since NoncopyableGenerics
is here.

(cherry picked from commit 1036031)
@kavon kavon force-pushed the 6.0-ncgeneric-not-experimental branch from d10a31d to 4dc39d0 Compare May 13, 2024 20:10
@kavon
Copy link
Member Author

kavon commented May 13, 2024

@swift-ci test

@kavon kavon requested review from krispymb and egorzhdan May 13, 2024 20:46
@kavon kavon marked this pull request as ready for review May 13, 2024 20:47
@kavon kavon requested a review from a team as a code owner May 13, 2024 20:47
@kavon kavon force-pushed the 6.0-ncgeneric-not-experimental branch from 4dc39d0 to 45b42be Compare May 13, 2024 21:12
@kavon
Copy link
Member Author

kavon commented May 13, 2024

@swift-ci test

@kavon kavon merged commit 78b635a into swiftlang:release/6.0 May 14, 2024
5 checks passed
@kavon kavon deleted the 6.0-ncgeneric-not-experimental branch May 14, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants