[RemoteInspection] Add TypeInfoProvider to ReflectionContext function #73713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass in a TypeInfoProvider parameter to computeUnalignedFieldStartOffset because it calls getClassInstanceTypeInfo which might need the external type info provider to find clang types. rdar://128141491 (cherry picked from commit 03b422b)
adrian-prantl
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Pass in a TypeInfoProvider parameter to computeUnalignedFieldStartOffset because it calls getClassInstanceTypeInfo which might need the external type info provider to find clang types.
Risk: Low, this is part of Remote Mirrors and doesn't affect the compiler. Also the change is simply threading a parameter which was simply set as null.
Testing: Added an lldb test.
Issue: rdar://128141491
Reviewer: @adrian-prantl
Original PR: #73684