Skip to content

[Concurrency] Refine getResumeFunctionForLogging to avoid reading invalid future contexts. #73796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2024

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented May 21, 2024

When using a future adapter, the resume context may not be valid after the task starts running. Only peer through the adapter when we're starting to run.

rdar://126298035

…alid future contexts.

When using a future adapter, the resume context may not be valid after the task starts running. Only peer through the adapter when we're starting to run.

rdar://126298035
@mikeash mikeash requested a review from ktoso as a code owner May 21, 2024 20:26
@mikeash
Copy link
Contributor Author

mikeash commented May 21, 2024

@swift-ci please test

@mikeash
Copy link
Contributor Author

mikeash commented May 22, 2024

@swift-ci please test macos platform

@mikeash
Copy link
Contributor Author

mikeash commented May 22, 2024

@swift-ci please smoke test macos platform

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mikeash mikeash merged commit 634295c into swiftlang:main May 22, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants