[Features] Move NoncopyableGenerics up. #73843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
approved these changes
May 23, 2024
| @@ -0,0 +1,16 @@ | |||
| // RUN: %empty-directory(%t) | |||
| // RUN: %target-swift-emit-module-interface(%t.swiftinterface) %s -module-name Mojuel | |||
There was a problem hiding this comment.
Minor: there seems to be an extra space before these RUN lines
Some compilers have the NoncopyableGenerics feature enabled via interesting mechanisms but do not have ConformanceSuppression. To support such compilers, the NoncopyableGenerics feature must appear before ConformanceSuppression in the list of features. Otherwise, when parsing the portion of the swiftinterface corresponding to an entity which involves both features, the first check will be for NoncopyableGenerics (which that old compiler has) and the code inside will involve ConformanceSuppression (which that old compiler does not have). rdar://128611158
nate-chandler
force-pushed
the
rdar128611158
branch
from
ff4ddd3 to
60cdbb8
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some compilers have the
NoncopyableGenericsfeature enabled via interesting mechanisms but do not haveConformanceSuppression. To support such compilers, theNoncopyableGenericsfeature must appear beforeConformanceSuppressionin the list of features. Otherwise, when parsing the portion of the swiftinterface corresponding to an entity which involves both features, the first check will be forNoncopyableGenerics(which that old compiler has) and the code inside will involveConformanceSuppression(which that old compiler does not have).rdar://128611158