[Macros] Don't allow macros to add accessors to let variables.
#73878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborla
requested review from
ktoso,
AnthonyLatsis,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
hborla
force-pushed
the
invalid-accessor-macro
branch
from
8aec86d to
3c6918a
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
letdeclarations cannot be computed properties, and accessor macros are currently allowed to bypass this rule. This was accidental, so this change diagnoses expanded accessors on aletvariable as an invalid macro expansion.Resolves: rdar://122690037, swiftlang/swift-syntax#2491