[BitwiseCopyable] Drop req from SIMD/Storage. #73890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
rdar128661878
branch
from
d373e95 to
023605d
Compare
There are conformers to SIMDStorage (like that in the added test case) which involve an Array (a type that can't conform to BitwiseCopyable). So lift the constraint on SIMDStorage. This in turn requires lifting the constraint on SIMD (otherwise, e.g. `SIMD8<Scalar>` would fail to conform since it has as a member some SIMD8Storage which is only constrained to conform to `SIMDStorage`; the `SIMD8Storage` associatedtype also cannot be constrained to `BitwiseCopyable` because that storage may again not conform as in the test example). rdar://128661878
nate-chandler
force-pushed
the
rdar128661878
branch
from
023605d to
746cf2f
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please apple silicon benchmark |
stephentyrone
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are conformers to
SIMDStorage(like that in the added test case) which involve an Array (a type that can't conform to BitwiseCopyable). So lift the constraint onSIMDStorage. This in turn requires lifting the constraint onSIMD(otherwise, e.g.SIMD8<Scalar>would fail to conform since it has as a member someSIMD8Storagewhich is only constrained to conform toSIMDStorage; theSIMD8Storageassociatedtype also cannot be constrained toBitwiseCopyablebecause that storage may again not conform as in the test example).rdar://128661878