Skip to content

Copy over EarlySwiftDriver executables on Debug builds by specifying the correct driver build directory #73893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2024

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented May 24, 2024

Following the same logic as EarlySwiftDriver.py product's is_release method which determines its configuration.

@artemcm
Copy link
Contributor Author

artemcm commented May 24, 2024

@swift-ci test

@artemcm artemcm force-pushed the DebugBuildEarlySwiftDriverCopy branch from 3a8b7e2 to 8093861 Compare May 24, 2024 17:56
@artemcm
Copy link
Contributor Author

artemcm commented May 24, 2024

@swift-ci test

@artemcm artemcm force-pushed the DebugBuildEarlySwiftDriverCopy branch from 8093861 to da33e04 Compare May 24, 2024 18:42
@artemcm
Copy link
Contributor Author

artemcm commented May 24, 2024

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented May 24, 2024

@swift-ci test macOS platform

@artemcm artemcm requested a review from felipepiovezan May 28, 2024 16:03
Copy link
Contributor

@felipepiovezan felipepiovezan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this!

@artemcm artemcm merged commit 5545581 into swiftlang:main May 28, 2024
5 checks passed
@artemcm artemcm deleted the DebugBuildEarlySwiftDriverCopy branch May 28, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants