[docs] Suggest --skip-xros in the Getting Started guide
#74257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Getting Started guide offers a build-script command that new contributors can use to quickly build a debug compiler on their local machine. The command already has `--skip-tvos` and `--skip-watchos` flags since most compiler contributors don't need to build for those platforms. This change adds `--skip-xros` flag to the command.
egorzhdan
requested review from
AnthonyLatsis,
LucianoPAlmeida and
xedin
as code owners
AnthonyLatsis
approved these changes
Jun 10, 2024
|
@swift-ci please smoke test |
|
@xedin Can you afford to poll the team for how many people and how often they intentionally omit these |
LucianoPAlmeida
approved these changes
Jun 10, 2024
|
I like @AnthonyLatsis's idea of inverting the default for these flags. That's how it already works if you invoke CMake directly which I normally do: unless you specified more SDKs in I think that should probably happen in a separate patch, if anyone's happy to work on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Getting Started guide offers a build-script command that new contributors can use to quickly build a debug compiler on their local machine. The command already has
--skip-tvosand--skip-watchosflags since most compiler contributors don't need to build for those platforms. This change adds--skip-xrosflag to the command.