SILGen: Fix corner-case in emission of extension initializer #7441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
If the initializer is in a different file than the original type, and the original type contains a stored property that has both an initializer *and* a declared type, then the initializer expression will not have been type checked. So we must look at the type of pattern, which should still be correct. Fixes <https://bugs.swift.org/browse/SR-3942> and <rdar://problem/25705157>.
slavapestov
force-pushed
the
fix-silgen-extension-initializer
branch
from
4e93834 to
2fac864
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the initializer is in a different file than the original
type, and the original type contains a stored property that
has both an initializer and a declared type, then the
initializer expression will not have been type checked.
So we must look at the type of pattern, which should still
be correct.
Fixes https://bugs.swift.org/browse/SR-3942 and
rdar://problem/25705157.