[6.0][concurrency] Mark the global _emptyDequeStorage as nonisolated(unsafe). #74562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We just use it as a way to initialize values. We will always just read from it and copy from it. (cherry picked from commit 7e8daa8)
|
@swift-ci test |
|
@swift-ci test macOS |
|
Ci had an outage, restarted mac CI |
ktoso
approved these changes
Jun 20, 2024
hborla
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This is just an internal global that is only written to during initialization. I validated together with @ktoso that there aren't any write uses to it. This just turns off a warning in the concurrency library due to strict concurrency.
Original PRs:
Risk: Low.
Testing: N/A.
Reviewer: @ktoso