[cxx-interop] Instantiate the std::function constructor with a const pointer argument
#74619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t pointer argument We were trying to instantiate a constructor for `std::function` from a C function pointer with a non-const function pointer type. That worked well on most platforms, where `std::function` defines a single constructor for const and non-const function pointers, but failed on UBI 9. This fixes a test (`Interop/Cxx/stdlib/use-std-function.swift`) on UBI Linux. rdar://118026392
egorzhdan
requested review from
hyp,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please test UBI9 |
|
@swift-ci Please Build Toolchain UBI9 |
|
@swift-ci please smoke test |
|
The build failure on UBI9 is unrelated to this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were trying to instantiate a constructor for
std::functionfrom a C function pointer with a non-const function pointer type. That worked well on most platforms, wherestd::functiondefines a single constructor for const and non-const function pointers, but failed on UBI 9.This fixes a test (
Interop/Cxx/stdlib/use-std-function.swift) on UBI Linux.rdar://118026392