[6.0][region-isolation] Add 'inout sending' diagnostics. #74924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so we can attach a Kind and propagate it. The reason why I am doing this is that I am adding support for failing to reinitialize an inout sending parameter that was transferred. To make it really easy to do I am just going to explicitly represent this on the RequireInst and let the decision on what diagnostic to be done to be represented in the pseudo-IR instead of trying to just infer it straight from the type of require inst. This keeps all of the logic in the same place and attempts to keep the diagnostic emitter not use logic and instead just emit. This is NFC so I can make sure that things work before adding the additional code. (cherry picked from commit 5d4b93f)
…ther tests. NFC. (cherry picked from commit bd06c82)
Specifically: 1. We error now if one transfers an 'inout sending' parameter and does not reinitialize it before the end of the function. 2. We error now if one merges an 'inout sending' parameter into an actor isolated region and do not reinitialize it with a non-actor isolated value before the end of the function. rdar://126303739 (cherry picked from commit 6fe7496)
|
@swift-ci test |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
DougGregor
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This PR adds support for 'inout sending' diagnostics. Specifically:
We error now if one transfers an 'inout sending' parameter and does not
reinitialize it before the end of the function.
We error now if one merges an 'inout sending' parameter into an actor
isolated region and do not reinitialize it with a non-actor isolated value
before the end of the function.
Radars:
Original PRs:
Risk: Low. This just adds 2 additional diagnostics to close a hole in the model.
Testing: Added/Ran tests
Reviewer: N/A