[6.0] SILGen: Reabstract subexpr lvalue before ABISafeConversion. #75194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rdar://130016855. When preconcurrency compatibility introduces implicit `@Sendable` conversions, the `ABISafeConversionExpr` representing that conversion indicates an ABI-neutral conversion from the substituted type of the original expression, so we need to reabstract in cases where the original property is more generic than the type we're working with.
jckarter
changed the title
|
@swift-ci Please test |
hborla
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes a compiler crash and/or miscompile when accessing a property of function type, in a generic context, from an extension with same-type constraints, in Swift 5 mode with implicit
@Sendableconversions introduced.Scope: Bug fix.
Issue: rdar://130016855
Original PR: #75193
Risk: Low. Fixes a relatively rare problem introduced by strict concurrency checking.
Testing: Test case from bug report, Swift CI
Reviewer: @xedin