Skip to content

[6.0🍒] NCGenerics: remove the reverse-condfail workaround #75214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kavon
Copy link
Member

@kavon kavon commented Jul 12, 2024

  • Explanation: Removes a condfail workaround that created a difference between how extensions in .swiftinterface files are interpreted vs in regular .swift.
  • Scope: While not specifically addressing a known issue, there may be undiscovered consequences of interpreting swiftinterface files differently.
  • Issue: rdar://131560183
  • PR: NCGenerics: remove the reverse-condfail workaround #75183
  • Risk: Low
  • Testing: Swift CI.
  • Reviewer: TBD

This should no longer be needed, after having staged the first set of
changes in, as it was a temporary workaround.

resolves rdar://131560183

(cherry picked from commit 5b2f2cb)
@kavon kavon requested a review from a team as a code owner July 12, 2024 21:42
@kavon kavon requested a review from tshortli July 12, 2024 21:42
@kavon
Copy link
Member Author

kavon commented Jul 12, 2024

@swift-ci test

@kavon kavon changed the title NCGenerics: remove the reverse-condfail workaround [6.0🍒] NCGenerics: remove the reverse-condfail workaround Jul 12, 2024
@kavon kavon marked this pull request as draft July 15, 2024 19:07
@kavon
Copy link
Member Author

kavon commented Jul 15, 2024

There isn't a specific need for this change at this time.

@kavon kavon closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant