[CS] A couple of minor diagnostic improvements #75239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invalid decls won't match any overrides in the base class, so avoid diagnosing that they don't override anything.
We were previously checking the optional type, which would never say that parens were needed. Unwrap the type before checking, ensuring we correctly handle e.g protocol compositions.
Previously we could end up with a ContextualMismatch fix and a MissingConformance fix for different elements of the `matchTypes` disjunction, leading to an ambiguity. Instead, avoid recording the ContextualMismatch if we're matching an existential, and tweak the MissingConformance failure to have a custom diagnostic for EnumElementPattern matching.
|
@swift-ci please test |
xedin
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
weak