utils: raise PinnedVersion to an argument
#75956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required so that we can use a custom pinned toolchain. The three arguments required are: - `PinnedBuild` (URL to toolchain) - `PinnedSHA256` (SHA256 for installer) - `PinnedVersion` (toolchain version) Prior to this, we would error out as `PinnedVersion` would be unset and could not be specified as it was not an argument.
|
CC: @hjyamauchi @hyp |
|
@swift-ci please test |
hjyamauchi
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required so that we can use a custom pinned toolchain. The three arguments required are:
PinnedBuild(URL to toolchain)PinnedSHA256(SHA256 for installer)PinnedVersion(toolchain version)Prior to this, we would error out as
PinnedVersionwould be unset and could not be specified as it was not an argument.