[index] For extensions, relate the symbol reference that gets extended and base references with the extension symbol. #7622
+50
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d and base references with the extension symbol. They were getting related with the original extended symbol, which was incorrect.
|
@swift-ci smoke test and merge |
slavapestov
reviewed
Feb 20, 2017
| if (getNameAndUSR(D, /*ExtD=*/nullptr, Name, USR)) | ||
| return true; | ||
| if (auto *ExtD = dyn_cast<ExtensionDecl>(D)) { | ||
| NominalTypeDecl *NTD = ExtD->getExtendedType()->getAnyNominal(); |
There was a problem hiding this comment.
Does this ever get called with invalid code? getExtendedType() might be null.
There was a problem hiding this comment.
No, in such a case IndexSwiftASTWalker::reportExtension would bail out early and addRelation would not get called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were getting related with the original extended symbol, which was incorrect.