Skip to content

[cxx-interop] Re-enable a test for C foreign reference types #76670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

egorzhdan
Copy link
Contributor

This test has been disabled since 2022.

This re-enables the test in order to have some test coverage of the -experimental-c-foreign-reference-types compiler flag.

See test/Interop/Cxx/foreign-reference/reference-counted.swift for a very similar test that enables C++ interop.

rdar://101790203

This test has been disabled since 2022.

This re-enables the test in order to have  some test coverage of the `-experimental-c-foreign-reference-types` compiler flag.

See `test/Interop/Cxx/foreign-reference/reference-counted.swift` for a very similar test that enables C++ interop.

rdar://101790203
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Sep 24, 2024
@egorzhdan egorzhdan requested a review from Xazax-hun September 24, 2024 12:02
@egorzhdan
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@Xazax-hun Xazax-hun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@egorzhdan egorzhdan merged commit 5925df7 into main Sep 25, 2024
5 checks passed
@egorzhdan egorzhdan deleted the egorzhdan/reenable-c-frt-test branch September 25, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants