[DiagnoseUnreachable] Ignore dead_end destroys. #77044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
tshortli
reviewed
Oct 16, 2024
Such destroys mark the lifetime end of their operands along their availability boundary. They are currently inserted in this test case by the ClosureLifetimeFixup pass, but in the fullness of time they will be present for every value which is not explicitly destroyed (that's what complete OSSA lifetimes is mostly about). Currently, such destroys are diagnosed by DiagnoseUnreachable. Fix the diagnostic pass not to diagnose these valid instructions. rdar://137960229
nate-chandler
force-pushed
the
rdar137960229
branch
from
5b44571 to
ce368e8
Compare
|
@swift-ci please test |
|
@swift-ci please smoke test macos platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such destroys mark the lifetime end of their operands along their availability boundary. They are currently inserted in this test case by the ClosureLifetimeFixup pass, but in the fullness of time they will be present for every value which is not explicitly destroyed (that's what complete OSSA lifetimes is mostly about).
Currently, such destroys are diagnosed by DiagnoseUnreachable. Fix the diagnostic pass not to diagnose these valid instructions.
rdar://137960229