Skip to content

[6.0] Ensure we are using mapped SIL type for switch_enum case and not the original lowered one #77107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

clackary
Copy link

@clackary clackary requested a review from a team as a code owner October 18, 2024 19:39
@clackary
Copy link
Author

@shahmishal I noticed there's a 6.0.2 branch. Not knowing how close the target release date is for that, would this have a chance of being included in 6.0.2 release?

We'd like to adopt release toolchains, but this is one blocker that would prevent us from doing so.

@asl
Copy link
Contributor

asl commented Oct 18, 2024

@clackary There were some other fixes to LoadableByAddress, notably:
#72619 and #72617

You might probably want to pick them as well (do not know if they are in 6.0 release branch, I'd assume – no).

@clackary
Copy link
Author

Looks like they weren't, so I've opened a few PRs for those also:
#77110
#77111

@DougGregor
Copy link
Member

@swift-ci please test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addresses an assertion and has been thoroughly tested on main. We'll take it

@DougGregor DougGregor merged commit f97c54b into swiftlang:release/6.0 Dec 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants