Fix DCE of load_borrow when it is derived from another borrow scope #77300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test Linux platform |
eeckstein
reviewed
Nov 4, 2024
| } | ||
| } | ||
| break; | ||
| } | ||
| case SILInstructionKind::LoadBorrowInst: { | ||
| findGuaranteedPhiDependencies(BorrowedValue(cast<LoadBorrowInst>(&I))); | ||
| auto *loadBorrowInst = cast<LoadBorrowInst>(&I); |
There was a problem hiding this comment.
Can you avoid this code duplication? Either by extracting it into a helper function or even merging the two switch cases
meg-gupta
force-pushed
the
dcebug2
branch
2 times, most recently
from
f2210b3 to
b407f2e
Compare
Fixes rdar://138663452
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a load_borrow was computed from another borrow scope, disable DCE of the parent borrow.
This is because when its reborrow is dead, DCE has to insert end_borrows in predecessor blocks and it cannot yet handle borrow nesting and can run into an issue if the parent borrow's reborrow is adjacent and dead.
Alternatively, we can allow DCE to insert end_borrows inside-out.
Fixes rdar://138663452