Skip to content

[Sema] NFC: Address review feedback on #77537 #77561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2024
Merged

[Sema] NFC: Address review feedback on #77537 #77561

merged 1 commit into from
Nov 13, 2024

Conversation

hamishknight
Copy link
Contributor

No description provided.

@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight mentioned this pull request Nov 12, 2024
Merged
xedin
xedin approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hamishknight hamishknight merged commit 9e5a105 into swiftlang:main Nov 13, 2024
4 of 5 checks passed
@hamishknight hamishknight deleted the completion-feedback branch November 13, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

@hborla hborla Awaiting requested review from hborla hborla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishknight @xedin