[cxx-interop] Support nested templates for conditional escapability #77678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
zoecarver,
hyp,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please smoke test |
egorzhdan
reviewed
Nov 19, 2024
| auto &argList = specDecl->getTemplateArgs(); | ||
| for (auto argToCheck : argumentsToCheck) { | ||
| auto arg = argList[argToCheck.first]; | ||
| if (arg.getKind() != clang::TemplateArgument::Type) { |
There was a problem hiding this comment.
I'm wondering if this would work with variadic templates, e.g. std::tuple? But that's out of scope of this patch 🙂
There was a problem hiding this comment.
Good point! I think this would not work for that. I'd address that in a follow-up PR.
| } | ||
| clang::DeclContext *rec = specDecl; | ||
| specDecl = nullptr; | ||
| while ((rec = rec->getParent())) { |
There was a problem hiding this comment.
Should this loop stop once rec->isTranslationUnit()?
There was a problem hiding this comment.
When rec->isTranslationUnit() is true, rec->getParent() returns null and the loop terminates. That being said, I just realized rec is a bit confusing name here.
There was a problem hiding this comment.
I see, that makes sense.
egorzhdan
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://140115862