[Completion] Fix Sendable KeyPath dynamic member subscripts #77691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `getKeyPathTypeForDynamicMemberLookup` which returns the KeyPath type, and can be used from both `RootAndResultTypeOfKeypathDynamicMemberRequest` and `isValidKeyPathDynamicMemberLookup`. This ensures we look to the superclass for e.g protocol compositions with `Sendable`. This also means we now return an interface type, which is what the client of `RootAndResultTypeOfKeypathDynamicMemberRequest` wanted anyway. rdar://138418296
hamishknight
requested review from
ahoppen,
bnbarham,
rintaro,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
ahoppen
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
getKeyPathTypeForDynamicMemberLookupwhich returns the KeyPath type, and can be used from bothRootAndResultTypeOfKeypathDynamicMemberRequestandisValidKeyPathDynamicMemberLookup. This ensures we look to the superclass for e.g protocol compositions withSendablefor completion. This also means we now return an interface type, which is what the client ofRootAndResultTypeOfKeypathDynamicMemberRequestwanted anyway.rdar://138418296
Resolves #77035