Skip to content

Avoid build error with Visual Studio 17.8.7 MSVC 19.38.33135.0 compiler #78222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2024
Merged

Avoid build error with Visual Studio 17.8.7 MSVC 19.38.33135.0 compiler #78222

merged 1 commit into from
Dec 17, 2024

Conversation

hjyamauchi
Copy link
Contributor

@hjyamauchi hjyamauchi commented Dec 16, 2024 •
edited
Loading

The error message from a local build:

S:\SourceCache\swift\include\swift/AST/ASTBridgingImpl.h(470): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'swift::Fingerprint'
S:\SourceCache\swift\include\swift/AST/ASTBridgingImpl.h(470): note: 'swift::Fingerprint::Fingerprint': ambiguous call to overloaded function
S:\SourceCache\swift\include\swift/Basic/Fingerprint.h(79): note: could be 'swift::Fingerprint::Fingerprint(swift::StableHasher &&)'
S:\SourceCache\swift\include\swift/Basic/Fingerprint.h(70): note: or       'swift::Fingerprint::Fingerprint(swift::Fingerprint::Core)'
S:\SourceCache\swift\include\swift/AST/ASTBridgingImpl.h(470): note: while trying to match the argument list '(initializer list)'
S

This might be a bug in that version of MSVC but it'd be great if we can compile with it as VS 17.9.x and 17.10.x have an arm64 miscompile bug: llvm/llvm-project#97631 https://developercommunity.visualstudio.com/t/VC-17103-arm64-C-compiler:-a-potenti/10699487

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test

@hjyamauchi hjyamauchi marked this pull request as ready for review December 17, 2024 00:44
@hjyamauchi hjyamauchi requested review from rintaro and compnerd and removed request for xedin, slavapestov and hborla December 17, 2024 00:44
compnerd
compnerd reviewed Dec 17, 2024
View reviewed changes
@hjyamauchi
Copy link
Contributor Author

@swift-ci please test

@hjyamauchi
Copy link
Contributor Author

@compnerd PTAL

@hjyamauchi hjyamauchi merged commit 283ce7f into swiftlang:main Dec 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@rintaro rintaro Awaiting requested review from rintaro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjyamauchi @compnerd