[6.1][IRGen] Indirectly pass typed errors for closures with indirect results #78273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
drexin
commented
Dec 18, 2024
drexin
commented
- Explanation: In partial application forwarder emission, we were missing a check for indirect results. When results are being returned indirectly, we have to return the error indirectly as well.
- Scope: Typed throws ABI
- Issues: rdar://141575655
- Original PRs: [IRGen] Indirectly pass typed errors for closures with indirect results #78261
- Risk: Low. Adjusts the code gen behavior to match other cases.
- Testing: Added regression tests for both cases. Ensured they failed before the fix.
- Reviewers: @aschwaighofer
rdar://141575655 In partial application forwarder emission, we were missing a check for indirect results. When results are being returned indirectly, we have to return the error indirectly as well.
|
@swift-ci test |
|
cc: @tbkka |
tbkka
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.