[CAS] Allow empty filename for diagnostics location #78406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
Fix a bug that an empty filename for diagnostics can trigger an error in the cached diagnostics. The empty filename can be a virtual file synthesized, for example, to hold an implicit attribute from clang importer. The cached diagnostics can correctly handle such filename now and cached/replay those diagnostics. rdar://141961161
cachemeifyoucan
force-pushed
the
eng/PR-141961161
branch
from
00548d8 to
ca87615
Compare
|
@swift-ci please smoke test |
benlangmuir
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug that an empty filename for diagnostics can trigger an error in the cached diagnostics. The empty filename can be a virtual file synthesized, for example, to hold an implicit attribute from clang importer.
The cached diagnostics can correctly handle such filename now and cached/replay those diagnostics.
rdar://141961161