[6.1][CSSimplify] CGFloat-Double: Fix ambiguity when assigning CGFloat to … #78547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…double property/variable Situations like: ``` let _: Double = <<CGFloat>> <var/property of type Double> = <<CGFloat>> ``` Used to be supported due to an incorrect fix added in diagnostic mode. Lower impact here means that right-hand side of the assignment is allowed to maintain CGFloat until the very end which minimizes the number of conversions used and keeps literals as Double when possible. Resolves: rdar://139675914 (cherry picked from commit 7c35c88)
|
@swift-ci please test |
bnbarham
approved these changes
Jan 10, 2025
DougGregor
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…double property/variable
Cherry-pick of #77592
Explanation:
Rectifying the fact that this didn't make it to 6.1 even though it should have.
Situations like:
Used to be supported due to an incorrect fix added in diagnostic mode.
Lower impact here means that right-hand side of the assignment is allowed
to maintain
CGFloatuntil the very end which minimizes the number ofconversions used and keeps literals as Double when possible.
Main Branch PR: [CSSimplify] CGFloat-Double: Fix ambiguity when assigning CGFloat to … #77592
Resolves: rdar://139675914
Risk: Low (the change is limited to assignments and affects only widening operators).
Reviewed By: @hborla
Testing: Added new tests to the Sema test suite.
(cherry picked from commit 7c35c88)