LifetimeDependenceDiagnostics; remove a bootstrapping hack. #78599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrick
requested review from
meg-gupta
and removed request for
jckarter and
eeckstein
|
@swift-ci test |
This temporary hack was preventing diagnostics from kicking in. This could even result in invalid SIL after the diagnostic failed to trigger.
Preserve ownership for empty non-trivial structs. This currently applies to ~Escapable structs. People often use empty structs to investigate language behavior. They should behave just like a struct that wraps a pointer. Previously, this would crash later during OSSA lifetime completion: Assertion failed: (isa<UnreachableInst>(block->getTerminator())), function computeRegion, file OSSALifetimeCompletion.cpp.
Use _overrideLifetime to avoid a diagnostic error.
atrick
force-pushed
the
fix-diagnostic-hack
branch
from
2c35728 to
8b02bd7
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This temporary hack was preventing diagnostics from kicking in. This could even result in invalid SIL after the diagnostic failed to trigger.
Add unit tests for lifetime dependence property access semantics.