AST: Only apply MemberImportVisibility to lookups from the main module #78876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
force-pushed
the
cfobject-hashable-member-import-visibility
branch
from
5f56847 to
d9d7c99
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
MemberImportVisibility rules should only apply to source code in the main module. The rules were being applied when resolving witnesses for synthesized Hashable conformances on CF types imported by ClangImporter, which caused the lookups to fail and bad conformances to be generated. Resolves swiftlang#78870 and rdar://142433039.
tshortli
force-pushed
the
cfobject-hashable-member-import-visibility
branch
from
d9d7c99 to
0b0d2e9
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test Windows platform |
xedin
approved these changes
Jan 24, 2025
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemberImportVisibilityrules should only apply to source code in the main module. The rules were being applied when resolving witnesses for synthesizedHashableconformances on CF types imported by ClangImporter, which caused the lookups to fail and bad conformances to be generated.Resolves #78870 and rdar://142433039.