Devirtualizer: fix de-virtualization of begin_apply #78886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle the special case of an guaranteed return value with no uses. Fixes an assertion crash. Unfortunately I don't have an isolated test case for this. But this problem showed up in the `Interpreter/moveonly_read_modify_coroutines.swift` test with OSSA modules and will therefore be tested by this test once we enable OSSA modules.
|
@swift-ci test |
|
LGTM. |
meg-gupta
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the special case of an guaranteed return value with no uses. Fixes an assertion crash.
Unfortunately I don't have an isolated test case for this. But this problem showed up in the
Interpreter/moveonly_read_modify_coroutines.swifttest with OSSA modules and will therefore be tested by this test once we enable OSSA modules.This is part of rdar://140229560.