Skip to content

[.editorconfig] Don't trim trailing whitespace #79005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jan 29, 2025

There is so much of it everywhere that opening any file in the project ends up creating large diffs which have nothing to do with the changes, test files are especially affected by this.

There is so much of it everywhere that opening any file
in the project ends up creating large diffs which have
nothing to do with the changes, test files are especially
affected by this.
@xedin xedin requested a review from MaxDesiatov January 29, 2025 08:33
@xedin
Copy link
Contributor Author

xedin commented Jan 29, 2025

@swift-ci please smoke test

@MaxDesiatov
Copy link
Contributor

It would be a shame to roll this back. WDYT of a PR cleaning this up in the whole project at once?

@xedin
Copy link
Contributor Author

xedin commented Jan 29, 2025

@MaxDesiatov Sure

@xedin
Copy link
Contributor Author

xedin commented Jan 31, 2025

I'm going to land this for now because it makes it really annoying to work with the code base with editors that respect the config. We can re-enable it once the whitespace is removed.

@xedin xedin merged commit f661374 into swiftlang:main Jan 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants