stdlib: add a missing fixLifetime in withVaList
#79056
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this function is inlined, the optimizer can shrink the lifetime of the `args` parameter. This would deallocate the passed arguments (e.g. `NSString`s) before the are used in the closure.
|
@swift-ci test |
meg-gupta
approved these changes
Jan 30, 2025
atrick
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Commentary: we need to enable lexical lifetimes in the stdlib for some important reasons such as
- avoiding bugs like this
- recurring bugs where devs copy code between the Swift module and other tests modules and expect consistent behavior
As Meghana explained, this is an array value without a lexical lifetime. And I don't think it matters how we build the stdlib given that @inlinable is required.
nate-chandler
approved these changes
Jan 31, 2025
|
@swift-ci smoke test windows |
|
This commit is already included in #78939 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this function is inlined, the optimizer can shrink the lifetime of the
argsparameter. This would deallocate the passed arguments (e.g.NSStrings) before the are used in the closure.This problem showed up in the
TestNSString.test_initializeWithFormat4swift-corelibs-foundation test (on linux) when enabling OSSA modules (#78939)