Skip to content

Serialization: Report deserialization remarks from lookup services #79092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Feb 1, 2025

Update the lookup services to prints remarks on deserialization errors attributed to broken modules. The remarks are controlled by the flag -Rmodule-recovery and were already active for most of the AST deserialization logic.

Now that Deserialization.cpp and ModuleFile.cpp consumes are updated to use diagnoseAndConsumeError instead of consumerError, all the AST deserialization logic should be covered by the remarks. The remaining calls to consumeError should only be for lower level issues like format errors that are not handled by the remarks.

@xymus
Copy link
Contributor Author

xymus commented Feb 1, 2025

@swift-ci Please smoke test

@xymus xymus force-pushed the more-serial-remarks branch from 83e9a7d to 66402f1 Compare February 3, 2025 19:20
@xymus
Copy link
Contributor Author

xymus commented Feb 3, 2025

@swift-ci Please smoke test

@xymus
Copy link
Contributor Author

xymus commented Feb 3, 2025

@swift-ci Please smoke test macOS

@xymus xymus merged commit 6852e0b into swiftlang:main Feb 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant