Serialization: Report deserialization remarks from lookup services #79092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the lookup services to prints remarks on deserialization errors attributed to broken modules. The remarks are controlled by the flag
-Rmodule-recovery
and were already active for most of the AST deserialization logic.Now that
Deserialization.cpp
andModuleFile.cpp
consumes are updated to usediagnoseAndConsumeError
instead ofconsumerError
, all the AST deserialization logic should be covered by the remarks. The remaining calls toconsumeError
should only be for lower level issues like format errors that are not handled by the remarks.