Skip to content

[Concurrency] dont use StdlibUnittest in async_task_escalate_priority #79603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Feb 25, 2025

Avoid StdlibUnittest so we have less noise and surprising interactions with it in CI.
Noticed a hard to explain crash which happened only once in CI which was about how StdlibUnitTests processes commands and I'd rather see the complete output than what we got from StdlibUnittest if there was a real issue there.

@ktoso
Copy link
Contributor Author

ktoso commented Feb 25, 2025

@swift-ci please smoke test

@ktoso ktoso enabled auto-merge (squash) February 25, 2025 05:13
@ktoso ktoso force-pushed the wip-dont-use-StdlibUnittest branch from 4b163c0 to bf911e4 Compare February 25, 2025 07:04
@ktoso
Copy link
Contributor Author

ktoso commented Feb 25, 2025

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Feb 25, 2025

@swift-ci please test Windows

@ktoso ktoso merged commit 7540abf into swiftlang:main Feb 25, 2025
3 checks passed
@ktoso ktoso deleted the wip-dont-use-StdlibUnittest branch February 25, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant