Skip to content

[ASTGen] Rework type specifiers #79630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

[ASTGen] Rework type specifiers #79630

merged 1 commit into from
Feb 26, 2025

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Feb 26, 2025

  • Handle multiple specifiers.
  • Handle previously missing sending specifiers.
  • Replicate C++ parser's specifier type wrapping logic.

@rintaro
Copy link
Member Author

rintaro commented Feb 26, 2025

@swift-ci Please smoke test

@rintaro rintaro force-pushed the astgen-typespecifiers branch 2 times, most recently from 605148c to 5cc8f46 Compare February 26, 2025 12:10
@rintaro
Copy link
Member Author

rintaro commented Feb 26, 2025

@swift-ci Please smoke test

@rintaro
[ASTGen] Rework type specifiers
0c23098 
Handle multiple specifiers. Hanle previously missing 'sending'
specifiers.
@rintaro rintaro force-pushed the astgen-typespecifiers branch from 5cc8f46 to 0c23098 Compare February 26, 2025 12:39
@rintaro
Copy link
Member Author

rintaro commented Feb 26, 2025

@swift-ci Please smoke test

@rintaro rintaro merged commit 361473c into swiftlang:main Feb 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishknight hamishknight hamishknight approved these changes

@ahoppen ahoppen Awaiting requested review from ahoppen

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@CodaFi CodaFi Awaiting requested review from CodaFi CodaFi is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @hamishknight