[6.2] Fix LifetimeDependence type inference for setters. #81271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
A setter on a non-Escapable type may have a dependency on both it's incoming 'self' and 'newValue'. If the 'newValue' dependency does not match the getter's dependency, then lifetime diagnostics will not accept the generated '_modify' accessor: error: lifetime-dependent value returned by generated accessor '_modify' To fix this, make sure that we don't (conservatively) infer a borrow dependency on 'newValue'. Fixes rdar://150444400 (cherry picked from commit 88bbc18)
(cherry picked from commit ce74ca3)
atrick
force-pushed
the
62-rdar150403948-lifedep-walker-recurse
branch
from
73991d7 to
cd343df
Compare
|
@swift-ci test |
meg-gupta
approved these changes
May 5, 2025
|
@swift-ci test macOS |
tbkka
approved these changes
May 5, 2025
|
Blocked on the continually failing |
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A setter on a non-Escapable type may have a dependency on both it's incoming
'self' and 'newValue'. If the 'newValue' dependency does not match the getter's
dependency, then lifetime diagnostics will not accept the generated '_modify'
accessor:
error: lifetime-dependent value returned by generated accessor '_modify'
To fix this, make sure that we don't (conservatively) infer a borrow
dependency on 'newValue'.
Fixes rdar://150444400
(cherry picked from commit 88bbc18)
main PR: #81270