[Concurrency] Use reinterpret_cast for function_cast when ptrauth is on. #81380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to use reinterpret_cast when ptrauth is enabled to ensure that any necessary auth-and-sign operations are performed. rdar://150747009
|
@swift-ci please test |
ktoso
approved these changes
May 8, 2025
compnerd
reviewed
May 9, 2025
| #if __has_feature(ptrauth_calls) | ||
| // Use reinterpret_cast here so we perform any necessary auth-and-sign. | ||
| #pragma clang diagnostic push | ||
| #pragma clang diagnostic ignored "-Wcast-function-type-mismatch" |
There was a problem hiding this comment.
I don't think that we should be silencing away this warning. This is technically UB, and the compiler is pointing that out.
There was a problem hiding this comment.
I don’t see any use in leaving it. The cast is necessary for correct behavior when ptrauth_calls is on, so we’d just have a warning we can’t address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use reinterpret_cast when ptrauth is enabled to ensure that any necessary auth-and-sign operations are performed.
rdar://150747009