Skip to content

[6.2][Distributed] pointer auth protocol pointers as we use conformsToProtocol #81394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented May 9, 2025

Description: We should be signing metadata pointers in the distributed runtime in order to avoid any future potential signing issues, and improve security of this lookup.
Scope/Impact: Low
Risk: Low, the identical pattern is done elsewhere.
Testing: Manually verified on arm64e
Reviewed by: @xedin @aschwaighofer who did similar changes around the codebase and knows the impact.

Original PR: #81372
Radar: rdar://150976815

@ktoso ktoso requested a review from a team as a code owner May 9, 2025 02:18
@ktoso
Copy link
Contributor Author

ktoso commented May 9, 2025

@swift-ci please test

@ktoso ktoso enabled auto-merge May 9, 2025 05:09
Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktoso ktoso merged commit d3248fc into swiftlang:release/6.2 May 9, 2025
5 checks passed
@ktoso ktoso deleted the pick-wip-sign-protocol-ptr branch May 9, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants