[CSGen] Prevent @concurrent on closures from skipping throws infe…
#81549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rence Introduction of `@concurrent` attribute caused an unintended side-effect in `ClosureEffectsRequest` since the attribute could only be used on `async` types setting `async` too early prevented body analysis for `throws` from running. Resolves: rdar://151421590
hborla
approved these changes
May 16, 2025
|
@swift-ci please smoke test |
AnthonyLatsis
approved these changes
May 16, 2025
hamishknight
added a commit
to hamishknight/swift
that referenced
this pull request
May 22, 2025
This reverts commit fd30319.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rence
Introduction of
@concurrentattribute caused an unintended side-effect inClosureEffectsRequestsince the attribute could only be used onasynctypes settingasynctoo early prevented body analysis forthrowsfrom running.Resolves: rdar://151421590