Skip to content

Update CI summary table on README to be more compact #81647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025

Conversation

marcprux
Copy link
Contributor

This PR updates the CI summary table in the README.md to summarize all architectures for a host to be on the same line with the architecture specified in the badge itself (rather than a generic "build" label), thereby enabling the whole CI status to be visible on a single page.

It also adds accessibility labels to each of the CI badges for Global Accessibility Awareness Month.

@finagolfin
Copy link
Member

Seems worthwhile, wdyt, @AnthonyLatsis?

@compnerd or @shahmishal, can we get rid of the VS 2019 entry, which says it is "currently disabled" and hasn't run in 3 months now?

Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I would also leave just the (sub)headers in bold in the left column.

@marcprux
Copy link
Contributor Author

Nice. I would also leave just the (sub)headers in bold in the left column.

OK, I've changed the sub-headers to be bold.

README.md Outdated
| **wasm32-unknown-wasi** |[![wasm32-unknown-wasi Build Status](https://ci.swift.org/job/oss-swift-pr-test-crosscompile-wasm-ubuntu-20_04/lastCompletedBuild/badge/icon)](https://ci.swift.org/job/oss-swift-pr-test-crosscompile-wasm-ubuntu-20_04)|
|**Community-Hosted CI Platforms**||
|**[Android](https://github.com/swiftlang/swift-community-hosted-continuous-integration/blob/main/nodes/x86_64_ubuntu_24_04_android.json)** | [![Android x86_64 Build Status](https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-24.04-android-build/lastCompletedBuild/badge/icon?subject=x86_64)](https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-24.04-android-build) [![Android aarch64 Build Status](https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-24.04-android-arm64/lastCompletedBuild/badge/icon?subject=aarch64)](https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-24.04-android-arm64)|
|**[Windows 2019 (VS 2019)](https://github.com/apple/swift-community-hosted-continuous-integration/blob/main/nodes/x86_64_windows_2019_VS2019.json)** | [![Windows 2019 x86_64 Build Status](https://ci-external.swift.org/job/oss-swift-windows-x86_64-vs2019/lastCompletedBuild/badge/icon?subject=x86_64)](https://ci-external.swift.org/job/oss-swift-windows-x86_64-vs2019)|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marc, remove this, can always put it back if someone complains later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all of them, or just the Windows 2019 line?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you, don't care, as we will need to remove the community Android CI once it's official anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the Windows 2019 line. I would prefer to leave Android in — when the CI becomes official, we will just be moving that line up.

@finagolfin
Copy link
Member

@swift-ci smoke test

@AnthonyLatsis
Copy link
Collaborator

OK, I've changed the sub-headers to be bold.

Sorry, I meant change the subheaders to be bold and everything else in the left column to not be bold.

@marcprux
Copy link
Contributor Author

Sorry, I meant change the subheaders to be bold and everything else in the left column to not be bold.

Done. That looks much better, IMO.

@finagolfin
Copy link
Member

@swift-ci smoke test

@AnthonyLatsis AnthonyLatsis enabled auto-merge (squash) May 27, 2025 20:25
@AnthonyLatsis AnthonyLatsis self-assigned this May 27, 2025
@AnthonyLatsis AnthonyLatsis merged commit cb3293b into swiftlang:main May 28, 2025
3 checks passed
@AnthonyLatsis AnthonyLatsis removed their assignment May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants